[PATCH net-next v4 5/5] net: dwmac_socfpga: initialize local data for mdio regmap configuration
Maxime Chevallier
maxime.chevallier at bootlin.com
Wed Jun 7 07:54:09 PDT 2023
On Wed, 7 Jun 2023 13:28:03 +0100
"Russell King (Oracle)" <linux at armlinux.org.uk> wrote:
> On Wed, Jun 07, 2023 at 03:59:41PM +0200, Maxime Chevallier wrote:
> > @@ -447,19 +446,22 @@ static int socfpga_dwmac_probe(struct platform_device *pdev)
> > struct mdio_regmap_config mrc;
> > struct regmap *pcs_regmap;
> > struct mii_bus *pcs_bus;
> >
> ...
> > + memset(&mrc, 0, sizeof(mrc));
> ...
> > mrc.parent = &pdev->dev;
> > mrc.valid_addr = 0x0;
> > + mrc.autoscan = false;
>
> Isn't this covered by the memset() ?
I have the same answer as for the above. It's redundant, but I don't
think there's any harm having it set explicitely ?
Maxime
More information about the linux-arm-kernel
mailing list