[PATCH v1] dt-bindings: nand: meson: Fix 'nand-rb' property

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Wed Jun 7 01:53:59 PDT 2023


On 07/06/2023 10:40, Arseniy Krasnov wrote:
> Hello Miquel, 
> 
> On 07.06.2023 10:58, Miquel Raynal wrote:
> 
>> Hi Arseniy,
>>
>> AVKrasnov at sberdevices.ru wrote on Tue, 6 Jun 2023 22:35:07 +0300:
>>
>>> Add description of 'nand-rb' property. Use "Fixes" because this property
>>> must be supported since the beginning. For this controller 'nand-rb' is
>>> stored in the controller node (not in chip), because it has only single
>>> r/b wire for all chips.
>>
>> Sorry if I mislead you in the first place, but you could definitely
>> have two chips and only one with RB wired. It needs to be defined in
>> the chips.
> 
> Ok, so to clarify: is it ok, that in bindings this property will be placed in the
> chip, but in driver, i'm trying to read it from the controller node (thus  in
> dts file it will be also in controller node)?

No, because how would your DTS pass validation? I understand you did not
test the bindings, but this will improve, right?

> Because in driver there is no sense
> to store this value in chip structure. 

Driver does not shape the DTS. Hardware does.



Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list