[PATCH 1/2] ARM: dts: samsung: exynos4x12: replace duplicate pmu node with phandle

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Sat Jul 22 04:56:17 PDT 2023


Devicetree for the FIMC IS camera included duplicated PMU node as its
child.  This is not a correct representation of the hardware.  Mapping
the PMU (Power Management Unit) IO memory should be via syscon-like
phandle (samsung,pmu-syscon, already used for other drivers), not by
duplicating "pmu" Devicetree node inside the FIMC IS.

The change is not compatible with older Linux kernel, which does not
parse samsung,pmu-syscon property.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>

---

Depends on:
https://lore.kernel.org/linux-devicetree/20230722115441.139628-1-krzysztof.kozlowski@linaro.org/T/#t
---
 arch/arm/boot/dts/samsung/exynos4x12.dtsi | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/samsung/exynos4x12.dtsi b/arch/arm/boot/dts/samsung/exynos4x12.dtsi
index 84c1db221c98..4524c1e6bb2f 100644
--- a/arch/arm/boot/dts/samsung/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4x12.dtsi
@@ -516,15 +516,12 @@ fimc_is: fimc-is at 12000000 {
 		iommus = <&sysmmu_fimc_isp>, <&sysmmu_fimc_drc>,
 			 <&sysmmu_fimc_fd>, <&sysmmu_fimc_mcuctl>;
 		iommu-names = "isp", "drc", "fd", "mcuctl";
+		samsung,pmu-syscon = <&pmu_system_controller>;
 		#address-cells = <1>;
 		#size-cells = <1>;
 		ranges;
 		status = "disabled";
 
-		pmu at 10020000 {
-			reg = <0x10020000 0x3000>;
-		};
-
 		i2c1_isp: i2c-isp at 12140000 {
 			compatible = "samsung,exynos4212-i2c-isp";
 			reg = <0x12140000 0x100>;
-- 
2.34.1




More information about the linux-arm-kernel mailing list