[PATCH 14/58] mmc: dw_mmc: exynos: Convert to platform remove callback returning void

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Thu Jul 13 01:11:15 PDT 2023


On 13/07/2023 10:07, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.

You even copied Uwe's commit msg... Aren't you duplicate his work or is
it being coordinated?

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list