[PATCH v2 net-next 6/9] net: ethernet: mtk_eth_soc: add MTK_NETSYS_V3 capability bit

[Russell King (Oracle)]

on thu, jul 13, 2023 at 03:19:49am +0100, daniel golle wrote:
> +
> +		if (mtk_has_caps(eth->soc->caps, mtk_netsys_v3)) {

this is a case in point for one of my previous comments...

this code started out believing that testing for mtk_netsys_v2 for v2
features would be sufficient. your first patch ended up having to
change that to !v1. how long until this becomes !v1 && !v2 because
it gets used on v3 and v4 etc?

this is why i think an integer version field would be a much saner
approach.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!