[PATCH 1/4] net: emaclite: Use devm_platform_get_and_ioremap_resource()

Alexander Lobakin aleksander.lobakin at intel.com
Thu Jul 6 05:29:22 PDT 2023


From: Yangtao Li <frank.li at vivo.com>
Date: Thu,  6 Jul 2023 20:08:47 +0800

> [PATCH 1/4] net: emaclite: Use devm_platform_get_and_ioremap_resource()

Please clearly specify the target tree (net or net-next) in the subject
prefix. Since your series is cleanups, it should be "PATCH net-next".

> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yangtao Li <frank.li at vivo.com>
> ---
>  drivers/net/ethernet/xilinx/xilinx_emaclite.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> index ad2c30d9a482..3cba947e4cbd 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> @@ -1114,8 +1114,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
>  
>  	ndev->irq = rc;
>  
> -	res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
> -	lp->base_addr = devm_ioremap_resource(&ofdev->dev, res);
> +	lp->base_addr = devm_platform_get_and_ioremap_resource(ofdev, 0, &res);
>  	if (IS_ERR(lp->base_addr)) {
>  		rc = PTR_ERR(lp->base_addr);
>  		goto error;

Thanks,
Olek



More information about the linux-arm-kernel mailing list