[PATCH net] net: phy: meson-gxl: use MMD access dummy stubs for GXL, internal PHY

Chris Healy cphealy at gmail.com
Tue Jan 31 13:07:03 PST 2023


Reviewed-by: Chris Healy <healych at amazon.com>

On Tue, Jan 31, 2023 at 1:03 PM Heiner Kallweit <hkallweit1 at gmail.com> wrote:
>
> Jerome provided the information that also the GXL internal PHY doesn't
> support MMD register access and EEE. MMD reads return 0xffff, what
> results in e.g. completely wrong ethtool --show-eee output.
> Therefore use the MMD dummy stubs.
>
> Note: The Fixes tag references the commit that added the MMD dummy
> access stubs.
>
> Fixes: 5df7af85ecd8 ("net: phy: Add general dummy stubs for MMD register access")
> Suggested-by: Jerome Brunet <jbrunet at baylibre.com>
> Signed-off-by: Heiner Kallweit <hkallweit1 at gmail.com>
> ---
>  drivers/net/phy/meson-gxl.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
> index c49062ad7..fbf5f2416 100644
> --- a/drivers/net/phy/meson-gxl.c
> +++ b/drivers/net/phy/meson-gxl.c
> @@ -261,6 +261,8 @@ static struct phy_driver meson_gxl_phy[] = {
>                 .handle_interrupt = meson_gxl_handle_interrupt,
>                 .suspend        = genphy_suspend,
>                 .resume         = genphy_resume,
> +               .read_mmd       = genphy_read_mmd_unsupported,
> +               .write_mmd      = genphy_write_mmd_unsupported,
>         }, {
>                 PHY_ID_MATCH_EXACT(0x01803301),
>                 .name           = "Meson G12A Internal PHY",
> --
> 2.39.1
>



More information about the linux-arm-kernel mailing list