[xilinx-xlnx:xlnx_rebase_v5.15_LTS_2022.1_update 404/1124] drivers/usb/dwc3/dwc3-xilinx.c:508:6: warning: no previous prototype for 'dwc3_xilinx_wakeup_capable'

kernel test robot lkp at intel.com
Sun Jan 29 03:40:39 PST 2023


Hi Piyush,

FYI, the error/warning still remains.

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS_2022.1_update
head:   5da20470af455bc588357712b64603b06e4edf42
commit: db6b55a74c709a27fdf6d175f890568dc8945424 [404/1124] usb: dwc3: Added remote wake-up in xilinx glue driver
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230129/202301291956.7mRsLiyf-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/Xilinx/linux-xlnx/commit/db6b55a74c709a27fdf6d175f890568dc8945424
        git remote add xilinx-xlnx https://github.com/Xilinx/linux-xlnx
        git fetch --no-tags xilinx-xlnx xlnx_rebase_v5.15_LTS_2022.1_update
        git checkout db6b55a74c709a27fdf6d175f890568dc8945424
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/usb/dwc3/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp at intel.com>

All warnings (new ones prefixed by >>):

>> drivers/usb/dwc3/dwc3-xilinx.c:508:6: warning: no previous prototype for 'dwc3_xilinx_wakeup_capable' [-Wmissing-prototypes]
     508 | void dwc3_xilinx_wakeup_capable(struct device *dev, bool wakeup)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/dwc3_xilinx_wakeup_capable +508 drivers/usb/dwc3/dwc3-xilinx.c

   506	
   507	/* xilinx feature support functions */
 > 508	void dwc3_xilinx_wakeup_capable(struct device *dev, bool wakeup)
   509	{
   510		struct device_node *node = of_node_get(dev->parent->of_node);
   511	
   512		/* check for valid parent node */
   513		while (node) {
   514			if (of_device_is_compatible(node, "xlnx,zynqmp-dwc3") ||
   515			    of_device_is_compatible(node, "xlnx,versal-dwc3"))
   516				break;
   517	
   518			/* get the next parent node */
   519			node = of_get_next_parent(node);
   520		}
   521	
   522		if (node) {
   523			struct platform_device *pdev_parent;
   524			struct dwc3_xlnx *priv_data;
   525	
   526			pdev_parent = of_find_device_by_node(node);
   527			priv_data = platform_get_drvdata(pdev_parent);
   528	
   529			/* Set wakeup capable as true or false */
   530			priv_data->wakeup_capable = wakeup;
   531	
   532			/* Allow D3 state if wakeup capable only */
   533			priv_data->enable_d3_suspend = wakeup;
   534		}
   535	}
   536	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests



More information about the linux-arm-kernel mailing list