[PATCH v2 4/5] arm64: add ARM64_HAS_GIC_PRIO_RELAXED_SYNC cpucap

Marc Zyngier maz at kernel.org
Thu Jan 26 00:31:29 PST 2023


On Wed, 25 Jan 2023 16:38:25 +0000,
Mark Rutland <mark.rutland at arm.com> wrote:

[...]

> @@ -1768,16 +1759,8 @@ static void gic_enable_nmi_support(void)
>  	for (i = 0; i < gic_data.ppi_nr; i++)
>  		refcount_set(&ppi_nmi_refs[i], 0);
>  
> -	/*
> -	 * Linux itself doesn't use 1:N distribution, so has no need to
> -	 * set PMHE. The only reason to have it set is if EL3 requires it
> -	 * (and we can't change it).
> -	 */

I think this is still an important comment as it gives a rationale for
the extra synchronisation even if Linux doesn't use 1:N distribution:
If you get secure interrupts in the non-secure priority space, they
are subjected to the NS PMR setting.

Could you find a new home for it?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.



More information about the linux-arm-kernel mailing list