[PATCH 01/10] dt-bindings: pinctrl: qcom: add IPQ5332 pinctrl

[Kathiravan Thirumoorthy]

On 1/25/2023 9:50 PM, Krzysztof Kozlowski wrote:
> On 25/01/2023 16:49, Kathiravan Thirumoorthy wrote:
>>>> @@ -0,0 +1,134 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/pinctrl/qcom,ipq5332-pinctrl.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Qualcomm IPQ5332 TLMM pin controller
>>>> +
>>>> +maintainers:
>>>> +  - Bjorn Andersson <andersson at kernel.org>
>>>> +  - Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>>>> +
>>>> +description: |
>>>> +  Top Level Mode Multiplexer pin controller in Qualcomm IPQ5332 SoC.
>>>> +
>>>> +allOf:
>>>> +  - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
>>>> +
>>>> +properties:
>>>> +  compatible:
>>>> +    const: qcom,ipq5332-tlmm
>>>> +
>>>> +  reg:
>>>> +    maxItems: 1
>>>> +
>>>> +  interrupts: true
>>> missing maxItems
>>>
>>> Rebase your patches on latest next and use the latest bindings and
>>> drivers as starting point.
>>
>> Changes are based on v6.2-rc1.  I see the maxItems changes in
>> linux-next. Will update this in V2.
> Your patches cannot be based on v6.2-rc1. They won't even apply. You
> miss entire development of last month.


Hmmm, Will use linux-next/master as base hereafter.


>>
>>>> +  interrupt-controller: true
>>>> +  "#interrupt-cells": true
>>>> +  gpio-controller: true
>>>> +  "#gpio-cells": true
>>>> +  gpio-ranges: true
>>>> +  wakeup-parent: true
>>>> +
>>>> +  gpio-reserved-ranges:
>>>> +    minItems: 1
>>>> +    maxItems: 27
>>>> +
>>>> +  gpio-line-names:
>>>> +    maxItems: 53
>>> You have 54 GPIOs.
>>
>> Sorry, GPIO ranges are from 0-52, will update it in all places in V2.
> Ah, then the gpio pattern needs a fix.


Yup, will take care of that as well in V2.


>
>
> Best regards,
> Krzysztof
>