[PATCH v1 3/7] serial: imx: do not sysrq broken chars
Stefan Wahren
stefan.wahren at i2se.com
Sat Jan 21 08:12:07 PST 2023
Hi Sergey,
Am 21.01.23 um 16:36 schrieb Sergey Organov:
> Do not call uart_handle_sysrq_char() if we got any receive error along with
> the character, as we don't want random junk to be considered a sysrq.
>
> Signed-off-by: Sergey Organov <sorganov at gmail.com>
this looks like a bugfix to me. Since the relevant code is pretty old,
i'm not sure about the fixes tag here:
Fixes: 279a9acc9b72 ("2.6.11 import") ?
> ---
> drivers/tty/serial/imx.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index e7fce31e460d..e709118fe85c 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -911,9 +911,6 @@ static irqreturn_t __imx_uart_rxint(int irq, void *dev_id)
> continue;
> }
>
> - if (uart_handle_sysrq_char(&sport->port, (unsigned char)rx))
> - continue;
> -
> if (unlikely(rx & URXD_ERR)) {
> if (rx & URXD_BRK)
> sport->port.icount.brk++;
> @@ -942,6 +939,8 @@ static irqreturn_t __imx_uart_rxint(int irq, void *dev_id)
> flg = TTY_OVERRUN;
>
> sport->port.sysrq = 0;
> + } else if (uart_handle_sysrq_char(&sport->port, (unsigned char)rx)) {
> + continue;
> }
>
> if (sport->port.ignore_status_mask & URXD_DUMMY_READ)
More information about the linux-arm-kernel
mailing list