[PATCH 3/3] coresight etm4x: Add pr_debug statement for Coresight component PID/CID

[Steve Clevenger]

Hi Russell,

Comments inline.

Steve

On 1/20/2023 4:40 AM, Russell King (Oracle) wrote:
> On Fri, Jan 20, 2023 at 11:23:53AM +0000, Suzuki K Poulose wrote:
>>
>> Cc: Russell
>>
>> nit: Subject line doesn't match the patch. This could be :
>>
>>  "amba: bus: Add pr_debug for AMBA PID/CID"
>>
>> On 20/01/2023 00:51, Steve Clevenger wrote:
>>> Add pr_debug statement to provide visibility into Coresight component PID
>>> and CID settings. This helped debug an intermittent clock related issue
>>> resulting in bad PID/CID values.
>>
>> And this change belongs to the AMBA subsystem. Please run :
>>
>> scripts/get_maintainer.pl on your patch and add the necessary people from
>> that list for your patch.
>>
>> As such, I don't think brings any value to be added to the tree.
>> I will leave it for the maintainers to comment.
> 
> Looking at the context in this patch, I see code that is reading at
> least the CID but likely also the PID from the device, duplicating
> the code that is already in the bus layer, and stored in the
> amba_device's periphid and cid members...
> 
The idea here was to capture and report an intermittent Ampere PID/CID
read error at the first read. It's not going to disturb me if this patch
is not considered value added, but it served its' purpose in this case
so I thought it might be useful for others to turn on under debug. I can
resubmit the patch for AMBA, or not.