[PATCH V4 2/4] ARM: dts: imx6ull-dhcom: Add DH electronics DHCOM i.MX6ULL SoM and PDK2 board

Marek Vasut marex at denx.de
Fri Jan 20 12:11:51 PST 2023


On 1/20/23 19:47, Christoph Niedermaier wrote:

[...]

> diff --git a/arch/arm/boot/dts/imx6ull-dhcom-pdk2.dts b/arch/arm/boot/dts/imx6ull-dhcom-pdk2.dts
> new file mode 100644

[...]

> +/* DHCOM I2C1 */
> +&i2c2 {
> +	sgtl5000: audio-codec at a {
> +		compatible = "fsl,sgtl5000";
> +		reg = <0x0a>;
> +		#sound-dai-cells = <0>;
> +		clocks = <&clk_ext_audio_codec>;
> +		VDDA-supply = <&reg_pdk2_3v3>;
> +		VDDIO-supply = <&reg_pdk2_3v3>;
> +	};
> +
> +	touchscreen at 38 {
> +		compatible = "edt,edt-ft5x06";

Sorry, I missed this one (checkpatch --strict does warn about it):

WARNING: DT compatible string "edt,edt-ft5x06" appears un-documented -- 
check ./Documentation/devicetree/bindings/
#316: FILE: arch/arm/boot/dts/imx6ull-dhcom-pdk2.dts:198:
+               compatible = "edt,edt-ft5x06";

I think here the correct compatible is:

Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml: 
  - edt,edt-ft5406

> +		reg = <0x38>;
> +		interrupt-parent = <&gpio5>;
> +		interrupts = <4 IRQ_TYPE_EDGE_FALLING>; /* GPIO E */
> +		power-supply = <&reg_panel_3v3>;
> +	};
> +};

With that fixed:

Reviewed-by: Marek Vasut <marex at denx.de>



More information about the linux-arm-kernel mailing list