[PATCH v4 12/17] arm64: dts: freescale: apalis-imx8: analogue audio comment

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Wed Jan 18 06:36:22 PST 2023


On 18/01/2023 15:33, Marcel Ziswiler wrote:
> On Wed, 2023-01-18 at 14:59 +0100, Krzysztof Kozlowski wrote:
>> On 18/01/2023 08:26, Marcel Ziswiler wrote:
>>> From: Marcel Ziswiler <marcel.ziswiler at toradex.com>
>>>
>>> Added a comment about Apalis analogue audio being another todo.
>>>
>>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler at toradex.com>
>>
>> You just added this file in previous patch. This should be squashed
>> instead of splitting one logical change (adding new hardware) into
>> multiple independent patches.
> 
> Remember, I explicitly did that for review purpose and even mentioned this in the cover letter.

There is b4 diff for this purpose. Splitting patches makes them
difficult to apply and confuse.

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list