[PATCH 04/19] bus/cdx: add MCDI protocol interface for firmware interaction

[Gupta, Nipun]

[AMD Official Use Only - General]



> -----Original Message-----
> From: Greg KH <gregkh at linuxfoundation.org>
> Sent: Tuesday, January 17, 2023 7:38 PM
> To: Gupta, Nipun <Nipun.Gupta at amd.com>
> Cc: robh+dt at kernel.org; krzysztof.kozlowski+dt at linaro.org; rafael at kernel.org;
> eric.auger at redhat.com; alex.williamson at redhat.com; cohuck at redhat.com;
> song.bao.hua at hisilicon.com; mchehab+huawei at kernel.org; maz at kernel.org;
> f.fainelli at gmail.com; jeffrey.l.hugo at gmail.com; saravanak at google.com;
> Michael.Srba at seznam.cz; mani at kernel.org; yishaih at nvidia.com;
> jgg at ziepe.ca; jgg at nvidia.com; robin.murphy at arm.com; will at kernel.org;
> joro at 8bytes.org; masahiroy at kernel.org; ndesaulniers at google.com; linux-arm-
> kernel at lists.infradead.org; linux-kbuild at vger.kernel.org; linux-
> kernel at vger.kernel.org; devicetree at vger.kernel.org; okaya at kernel.org;
> Anand, Harpreet <harpreet.anand at amd.com>; Agarwal, Nikhil
> <nikhil.agarwal at amd.com>; Simek, Michal <michal.simek at amd.com>; git
> (AMD-Xilinx) <git at amd.com>
> Subject: Re: [PATCH 04/19] bus/cdx: add MCDI protocol interface for firmware
> interaction
> 
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
> 
> 
> On Tue, Jan 17, 2023 at 07:11:36PM +0530, Nipun Gupta wrote:
> > +/** Request/Response structure */
> > +#define MCDI_HEADER_OFST 0
> > +#define MCDI_HEADER_CODE_LBN 0
> > +#define MCDI_HEADER_CODE_WIDTH 7
> > +#define MCDI_HEADER_RESYNC_LBN 7
> > +#define MCDI_HEADER_RESYNC_WIDTH 1
> > +#define MCDI_HEADER_DATALEN_LBN 8
> > +#define MCDI_HEADER_DATALEN_WIDTH 8
> > +#define MCDI_HEADER_SEQ_LBN 16
> > +#define MCDI_HEADER_SEQ_WIDTH 4
> > +#define MCDI_HEADER_RSVD_LBN 20
> > +#define MCDI_HEADER_RSVD_WIDTH 1
> > +#define MCDI_HEADER_NOT_EPOCH_LBN 21
> > +#define MCDI_HEADER_NOT_EPOCH_WIDTH 1
> > +#define MCDI_HEADER_ERROR_LBN 22
> > +#define MCDI_HEADER_ERROR_WIDTH 1
> > +#define MCDI_HEADER_RESPONSE_LBN 23
> > +#define MCDI_HEADER_RESPONSE_WIDTH 1
> > +#define MCDI_HEADER_XFLAGS_LBN 24
> > +#define MCDI_HEADER_XFLAGS_WIDTH 8
> 
> <snip>
> 
> This whole file could use some tabs to align all of the values for the
> defines to make it readable.  Any chance of doing that?

Yes sure. Will update this.

> 
> thanks,
> 
> greg k-h