[PATCH v3 12/15] iio: adc: qcom-spmi-adc5: convert to device properties

[Andy Shevchenko]

On Tue, Jan 17, 2023 at 11:06 AM Andy Shevchenko
<andy.shevchenko at gmail.com> wrote:
>
> On Tue, Jan 17, 2023 at 10:53 AM Andy Shevchenko
> <andy.shevchenko at gmail.com> wrote:
> >
> > On Mon, Jan 16, 2023 at 10:44 PM Marijn Suijten
> > <marijn.suijten at somainline.org> wrote:
> > >
> > > On 2022-08-06 19:20:48, Jonathan Cameron wrote:
> > > > On Fri, 15 Jul 2022 14:29:00 +0200
> > > > Nuno Sá <nuno.sa at analog.com> wrote:
> > > >
> > > > > Make the conversion to firmware agnostic device properties. As part of
> > > > > the conversion the IIO inkern interface 'of_xlate()' is also converted to
> > > > > 'fwnode_xlate()'. The goal is to completely drop 'of_xlate' and hence OF
> > > > > dependencies from IIO.
> > > > >
> > > > > Signed-off-by: Nuno Sá <nuno.sa at analog.com>
> > > > > Acked-by: Linus Walleij <linus.walleij at linaro.org>
> > > > > Reviewed-by: Andy Shevchenko <andy.shevchenko at gmail.com>
> > > > +CC Marijin who happend to post a patch for this driver that I just accepted
> > > > and hence probably has hardware access.  Any chance of a test for this series?
> > > >
> > > > If not, no problem as this is fairly mechanical and we have testing on some of
> > > > the other drivers using the new code.
> > > >
> > > > I'll probably queue this up in the meantime but it won't end up upstream
> > > > for a few weeks yet.
> > >
> > > Jonathan,
> > >
> > > This CC just surfaced in my inbox while searching for our current
> > > discussion around missing labels in qcom-spmi-vadc - and on the side a
> > > userspace @xx label name ABI break (in qcom-spmi-adc5) caused by this
> > > patch's fwnode_get_name change - we could've caught it if I had not
> > > accidentally marked it as read and/or forgot about it.  My apologies.
> >
> > Does the following addition to the top of the
> > adc5_get_fw_channel_data() fix the issue?
> >
> > +       name = devm_kasprintf(adc->dev, GFP_KERNEL, "%pfwP", fwnode);
> > +       if (!name)
> > +               return -ENOMEM;
>
> Okay, it probably the same, so it might need additional code to
>
> + name[strchrnul(name, '@') - name] = '\0';

I have just sent a formal patch, please test on top of non-working kernel.


--
With Best Regards,
Andy Shevchenko