[PATCH 2/2] arm64: dts: imx8mp: Add support for Data Modul i.MX8M Plus eDM SBC

[Ahmad Fatoum]

On 16.01.23 11:39, Marek Vasut wrote:
> On 1/11/23 08:38, Ahmad Fatoum wrote:
>> Could you share your get_maintainers.pl invocation? I'd like to
>> adjust the reviewer entry in MAINTAINERS, so such patches get
>> into our kernel at pengutronix.de inbox as well.
> 
> Plain get_maintainer -f path/to/dts

Ah. This doesn't contain /imx/ and thus didn't match the i.MX
MAINTAINERS entry at all. I just sent a patch to remedy this.

>>> +    pmic: pmic at 25 {
>>> +        compatible = "nxp,pca9450c";
>>> +        reg = <0x25>;
>>> +        pinctrl-names = "default";
>>> +        pinctrl-0 = <&pinctrl_pmic>;
>>> +        interrupt-parent = <&gpio1>;
>>> +        interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
>>> +        sd-vsel-gpios = <&gpio1 4 GPIO_ACTIVE_HIGH>;
>>
>> Here you assume GPIO1_IO04 is muxed as GPIO.
>>
>>> +    pinctrl_usdhc2: usdhc2-grp {
>>> +        fsl,pins = <
>>> +            MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT        0xc1
>>
>> Here you mux it for USDHC2_VSELECT though. Is this intended?
> 
> That's a good question, other DTs do the same thing, I suspect the sd-vsel-gpios could be dropped, but as long as it is not outright harmful, it can be used for backward compatibility to support less complete OSes which may not handle the eSDHC VSELECT bit , so I figured it is good to keep both options.

I'd assume any useful software will have support for the pinctrl
binding and once you mux the pad for USDHC2_VSELECT, it's not
useful to have a device trying to use the GPIO.

Cheers,
Ahmad

> 
> [...]
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |