[PATCH v3 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format
Tony Lindgren
tony at atomide.com
Thu Jan 12 23:06:06 PST 2023
Hi Rob,
* Rob Herring <robh at kernel.org> [221127 18:22]:
> On Wed, Nov 23, 2022 at 08:58:54AM +0200, Tony Lindgren wrote:
> > * Rob Herring <robh at kernel.org> [221123 02:31]:
> > > On Tue, Nov 22, 2022 at 02:32:24PM +0200, Tony Lindgren wrote:
> > > > --- a/Documentation/devicetree/bindings/pwm/pwm.yaml
> > > > +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
> > > > @@ -13,7 +13,7 @@ select: false
> > > >
> > > > properties:
> > > > $nodename:
> > > > - pattern: "^pwm(@.*|-[0-9a-f])*$"
> > > > + pattern: "^pwm(@.+|-[0-9a-f]+)?$"
> > >
> > > So now pwm-10 could be either?
> >
> > Yes.
> >
> > > I'm fine with decimal, but can we do that everywhere we do this -N
> > > naming?
> >
> > Do you mean the '[0-9a-f]' users that don't use '[0-9af]+'?
>
> No, I mean for all cases of <nodename>-N, can be we consistent. Either
> we use hex or we use decimal.
>
> >
> > These can be found with:
> >
> > $ find Documentation/devicetree/bindings/ -name \*.yaml | \
> > xargs grep pattern: | grep '\[0-9a-f\]' | grep -v '\[0-9a-f\]+'
>
> Not quite. It's just cases of '-N':
>
> $ find Documentation/devicetree/bindings/ -name \*.yaml | xargs grep pattern: | grep '\-\[0-9a-f\]' | grep -v '\[0-9a-f\]+'
> Documentation/devicetree/bindings/phy/intel,combo-phy.yaml: pattern: "combophy(@.*|-[0-9a-f])*$"
> Documentation/devicetree/bindings/pwm/pwm.yaml: pattern: "^pwm(@.*|-[0-9a-f])*$"
> Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml: pattern: "^timestamp(@.*|-[0-9a-f])?$"
> Documentation/devicetree/bindings/watchdog/watchdog.yaml: pattern: "^watchdog(@.*|-[0-9a-f])?$"
> Documentation/devicetree/bindings/spi/spi-controller.yaml: pattern: "^spi(@.*|-[0-9a-f])*$"
> Documentation/devicetree/bindings/rtc/rtc.yaml: pattern: "^rtc(@.*|-[0-9a-f])*$"
>
>
> And there's probably some more in dtschema.
Looking at this again, not exactly sure still what you want..
Can you please post some initial patch maybe, verbal patches are
a bit tricky :)
Regards,
Tony
More information about the linux-arm-kernel
mailing list