[PATCH 6/7] iommu: dart: Support different variants with different registers

[Hector Martin]

On 2023/01/04 22:43, Sven Peter wrote:
> On Wed, Jan 4, 2023, at 12:00, Hector Martin wrote:
>> +	u64 enable_streams;
>> +	u64 disable_streams;
> I don't think disable_streams is used anywhere. I assume you just left it in
> here to document it?

Yeah, we don't use this field ever, so we might as well drop it. I'll
leave the #define for T8110 in though, as documentation.

>> +	u64 ttbr;
>> +	u64 ttbr_valid;
>> +	u64 ttbr_addr_off;
> 
> This name confused me a bit since off sounds like offset to me while
> this is actually another shift. Can't really think of a better name
> right now though. I'd at least a comment here to describe it.

How about `ttbr_addr_field_shift`?

- Hector