[PATCH v2] soc: imx8m: fix wrong return value check of of_clk_get_by_name()
Yang Yingliang
yangyingliang at huawei.com
Wed Jan 4 01:27:02 PST 2023
of_clk_get_by_name() never returns NULL pointer, it will return
ERR_PTR() when it fails, so replace the check with IS_ERR().
Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the register")
Signed-off-by: Yang Yingliang <yangyingliang at huawei.com>
---
v1 -> v2:
Check WARN_ON() instead of checking IS_ERR().
---
drivers/soc/imx/soc-imx8m.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
index 28144c699b0c..d1dbe318be53 100644
--- a/drivers/soc/imx/soc-imx8m.c
+++ b/drivers/soc/imx/soc-imx8m.c
@@ -66,10 +66,8 @@ static u32 __init imx8mq_soc_revision(void)
ocotp_base = of_iomap(np, 0);
WARN_ON(!ocotp_base);
clk = of_clk_get_by_name(np, NULL);
- if (!clk) {
- WARN_ON(!clk);
+ if (WARN_ON(IS_ERR(clk)))
return 0;
- }
clk_prepare_enable(clk);
--
2.25.1
More information about the linux-arm-kernel
mailing list