[PATCH v2 3/3] ARM: dts: imx: Add support for SK-iMX53 board

Dmitry Baryshkov dmitry.baryshkov at linaro.org
Sun Jan 1 14:53:38 PST 2023


On Mon, 2 Jan 2023 at 00:51, Fabio Estevam <festevam at gmail.com> wrote:
>
> On Sun, Jan 1, 2023 at 3:46 PM Dmitry Baryshkov
> <dmitry.baryshkov at linaro.org> wrote:
>
> > +       mdio {
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +
> > +               phy0: ethernet-phy at 0 {
> > +                       reg = <0>;
> > +                       device_type = "ethernet-phy";
>
> I forgot to comment on this one in the previous review:
>  device_type = "ethernet-phy" does not look like a valid property.

Well, it's used by the kernel, but I can drop it.

>
> > +&vpu {
> > +       status = "okay";
> > +};
>
> This can be removed, as the vpu node is not disabled in imx53.dtsi.

Ugh. I thought that I removed it after v1 based on your feedback.

-- 
With best wishes
Dmitry



More information about the linux-arm-kernel mailing list