[PATCH v4 5/5] arm64: dts: imx8mp: Add analog audio output on i.MX8MP EVK

[Marek Vasut]

On 2/23/23 18:28, Fabio Estevam wrote:
> Hi Marek,

Hi,

> On Thu, Feb 23, 2023 at 2:11 PM Marek Vasut <marex at denx.de> wrote:
> 
>> +       reg_audio_pwr: regulator-audio-pwr {
>> +               compatible = "regulator-fixed";
>> +               regulator-name = "audio-pwr";
>> +               regulator-min-microvolt = <3300000>;
>> +               regulator-max-microvolt = <3300000>;
>> +               gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>;
>> +               enable-active-high;
>> +               regulator-always-on;
> 
> It seems that "regulator-always-on" could be removed as the regulator
> is controlled by the codec.

Ah yes

> Reviewed-by: Fabio Estevam <festevam at gmail.com>

Thanks