[PATCH 1/2] serial: stm32: Remove unused struct stm32_port txdone element

Marek Vasut marex at denx.de
Wed Feb 22 20:22:51 PST 2023


The txdone element is only ever assigned, once, and never used. Drop it.

Signed-off-by: Marek Vasut <marex at denx.de>
---
Cc: Alexandre Torgue <alexandre.torgue at foss.st.com>
Cc: Erwan Le Ray <erwan.leray at foss.st.com>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Cc: Jean Philippe Romain <jean-philippe.romain at foss.st.com>
Cc: Jiri Slaby <jirislaby at kernel.org>
Cc: Johan Hovold <johan at kernel.org>
Cc: Lukas Wunner <lukas at wunner.de>
Cc: Maxime Coquelin <mcoquelin.stm32 at gmail.com>
Cc: Valentin Caron <valentin.caron at foss.st.com>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-serial at vger.kernel.org
Cc: linux-stm32 at st-md-mailman.stormreply.com
---
 drivers/tty/serial/stm32-usart.c | 1 -
 drivers/tty/serial/stm32-usart.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
index 767ff9fdb2e58..bf51e2152dd5a 100644
--- a/drivers/tty/serial/stm32-usart.c
+++ b/drivers/tty/serial/stm32-usart.c
@@ -743,7 +743,6 @@ static void stm32_usart_transmit_chars(struct uart_port *port)
 		stm32_usart_tx_interrupt_disable(port);
 		if (!stm32_port->hw_flow_control &&
 		    port->rs485.flags & SER_RS485_ENABLED) {
-			stm32_port->txdone = true;
 			stm32_usart_tc_interrupt_enable(port);
 		}
 	}
diff --git a/drivers/tty/serial/stm32-usart.h b/drivers/tty/serial/stm32-usart.h
index 0ec41a732c888..903285b5aea75 100644
--- a/drivers/tty/serial/stm32-usart.h
+++ b/drivers/tty/serial/stm32-usart.h
@@ -203,7 +203,6 @@ struct stm32_port {
 	bool hw_flow_control;
 	bool swap;		 /* swap RX & TX pins */
 	bool fifoen;
-	bool txdone;
 	int rxftcfg;		/* RX FIFO threshold CFG      */
 	int txftcfg;		/* TX FIFO threshold CFG      */
 	bool wakeup_src;
-- 
2.39.1




More information about the linux-arm-kernel mailing list