[EXTERNAL] Re: [PATCH v10 1/9] dt-bindings: mfd: ti, j721e-system-controller: Fix mux node regex

Ravi Gunasekaran r-gunasekaran at ti.com
Tue Feb 21 20:38:13 PST 2023



On 21/02/23 10:34 pm, Rob Herring wrote:
> On Tue, Feb 21, 2023 at 8:00 AM Vignesh Raghavendra <vigneshr at ti.com> wrote:
>> On 21/02/23 5:36 pm, Ravi Gunasekaran wrote:
>>> mux-controller nodes may not have "reg" property. Update the regex
>>> for such nodes to resolve the dtbs warnings
>>>
>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran at ti.com>
>>> ---
> 
> Where's the change history? I doubt I ignored the last 9 versions...

This change was added newly in v8.
But based on the review comments, dtbs warnings can be fixed without
changes to bindings document. So this patch will be dropped in the next
series.

Ravi

> 
>>>  .../bindings/mfd/ti,j721e-system-controller.yaml          | 8 +++++++-
>>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
>>> index 76ef4352e13c..532bfa45e6a0 100644
>>> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
>>> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
>>> @@ -45,7 +45,7 @@ properties:
>>>
>>>  patternProperties:
>>>    # Optional children
>>> -  "^mux-controller@[0-9a-f]+$":
>>> +  "^mux-controller(@|-)[0-9a-f]+$":
>>
>> Hmm. mmio-mux bindings allow reg property. Why can't we add the same to
>> mux-controller node in 2/9 ?
> 
> Yes, do that.
> 
> Rob





More information about the linux-arm-kernel mailing list