[PATCH v3 5/5] pinctrl: at91: Utilise temporary variable for struct device
Claudiu.Beznea at microchip.com
Claudiu.Beznea at microchip.com
Fri Feb 17 03:54:02 PST 2023
On 15.02.2023 15:42, Andy Shevchenko wrote:
> @@ -1758,7 +1750,7 @@ static int at91_gpio_of_irq_setup(struct platform_device *pdev,
> if (!gpiochip_prev) {
> girq->parent_handler = gpio_irq_handler;
> girq->num_parents = 1;
> - girq->parents = devm_kcalloc(&pdev->dev, 1,
> + girq->parents = devm_kcalloc(dev, girq->num_parents,
There is still the change of the 2nd argument of devm_kcalloc() from 1 ->
girq->num_parents (no functional change, though) which doesn't match the
purpose of the patch and is not specified anywhere. Other than this:
Reviewed-by: Claudiu Beznea <claudiu.beznea at microchip.com>
> sizeof(*girq->parents),
> GFP_KERNEL);
More information about the linux-arm-kernel
mailing list