[PATCH v2 03/24] arm/cpu: Make sure arch_cpu_idle_dead() doesn't return
Josh Poimboeuf
jpoimboe at kernel.org
Mon Feb 13 23:05:37 PST 2023
arch_cpu_idle_dead() doesn't return. Make that more explicit with a
BUG().
BUG() is preferable to unreachable() because BUG() is a more explicit
failure mode and avoids undefined behavior like falling off the edge of
the function into whatever code happens to be next.
Signed-off-by: Josh Poimboeuf <jpoimboe at kernel.org>
---
arch/arm/kernel/smp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
index 0b8c25763adc..adcd417c526b 100644
--- a/arch/arm/kernel/smp.c
+++ b/arch/arm/kernel/smp.c
@@ -382,6 +382,8 @@ void arch_cpu_idle_dead(void)
: "r" (task_stack_page(current) + THREAD_SIZE - 8),
"r" (current)
: "r0");
+
+ BUG();
}
#endif /* CONFIG_HOTPLUG_CPU */
--
2.39.1
More information about the linux-arm-kernel
mailing list