[PATCH v2 1/2] ARM: dts: exynos: drop mshc aliases
Henrik Grimler
henrik at grimler.se
Thu Feb 9 06:56:53 PST 2023
Hi Krzysztof,
Thanks for reviewing!
On Thu, Feb 09, 2023 at 03:39:37PM +0100, Krzysztof Kozlowski wrote:
> On 28/01/2023 14:31, Henrik Grimler wrote:
> > They are no longer needed after commit a13e8ef6008d ("mmc: dw_mmc:
> > exynos: use common_caps").
> >
>
> Are you sure? That commit explicitly says that the caps should be set
> from DT and Exynos DT does not set it everywhere...
>
> plus if alias is missing, then the ctrl_id in dw_mmc.c is 0 and such
> caps are applied everywhere - to every DWMMC device.
Yeah, you are right, David pointed this out in the ARM64 patchset [1]
as well, so I will look it over again and send new versions (when
discussion on this version is finalised).
> Best regards,
> Krzysztof
[1] https://patchwork.kernel.org/project/linux-samsung-soc/patch/20230203204000.14410-2-henrik@grimler.se/#25197132
Best regards,
Henrik Grimler
More information about the linux-arm-kernel
mailing list