[PATCH net] net: bgmac: fix BCM5358 support by setting correct flags

Florian Fainelli f.fainelli at gmail.com
Wed Feb 8 10:40:31 PST 2023


On 2/8/23 01:16, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal at milecki.pl>
> 
> Code blocks handling BCMA_CHIP_ID_BCM5357 and BCMA_CHIP_ID_BCM53572 were
> incorrectly unified. Chip package values are not unique and cannot be
> checked independently. They are meaningful only in a context of a given
> chip.
> 
> Packages BCM5358 and BCM47188 share the same value but then belong to
> different chips. Code unification resulted in treating BCM5358 as
> BCM47188 and broke its initialization.
> 
> Link: https://github.com/openwrt/openwrt/issues/8278
> Fixes: cb1b0f90acfe ("net: ethernet: bgmac: unify code of the same family")
> Cc: Jon Mason <jdmason at kudzu.us>
> Signed-off-by: Rafał Miłecki <rafal at milecki.pl>

Reviewed-by: Florian Fainelli <f.fainelli at gmail.com>
-- 
Florian




More information about the linux-arm-kernel mailing list