[PATCH v2 3/3] efi: x86: Wire up IBT annotation in memory attributes table
Dave Hansen
dave.hansen at intel.com
Wed Feb 8 07:17:15 PST 2023
On 2/6/23 04:49, Ard Biesheuvel wrote:
> --- a/arch/x86/kernel/apm_32.c
> +++ b/arch/x86/kernel/apm_32.c
> @@ -609,7 +609,7 @@ static long __apm_bios_call(void *_call)
>
> apm_irq_save(flags);
> firmware_restrict_branch_speculation_start();
> - ibt = ibt_save();
> + ibt = ibt_save(true);
My only nit with these is the bare use of 'true'/'false'. It's
impossible to tell at the call-site what the 'true' means. So, if you
happen to respin these and see a nice way to remedy this I'd appreciate it.
But they're still OK as-is. For the x86 bits:
Acked-by: Dave Hansen <dave.hansen at linux.intel.com>
More information about the linux-arm-kernel
mailing list