[PATCH net] net: phy: meson-gxl: use MMD access dummy stubs for GXL, internal PHY

Kevin Hao haokexin at gmail.com
Wed Feb 1 04:45:58 PST 2023


On Tue, Jan 31, 2023 at 09:55:28PM -0800, Jakub Kicinski wrote:
> On Tue, 31 Jan 2023 22:03:21 +0100 Heiner Kallweit wrote:
> > Jerome provided the information that also the GXL internal PHY doesn't
> > support MMD register access and EEE. MMD reads return 0xffff, what
> > results in e.g. completely wrong ethtool --show-eee output.
> > Therefore use the MMD dummy stubs.
> > 
> > Note: The Fixes tag references the commit that added the MMD dummy
> > access stubs.
> > 
> > Fixes: 5df7af85ecd8 ("net: phy: Add general dummy stubs for MMD register access")
> 
> Please make sure to CC the author. Adding Kevin Hao <haokexin at gmail.com>

The changes look fine to me, but the using of the "Fixes" tag seems a bit weird.
The "Fixes" tag is used to specify the commit causing regression instead of patch prerequisite.

Thanks,
Kevin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20230201/69892557/attachment.sig>


More information about the linux-arm-kernel mailing list