[PATCH v2 1/8] dt-bindings: marvell: a38x: convert the soc compatibles description to yaml

Josua Mayer josua at solid-run.com
Sun Dec 24 07:45:48 PST 2023


Am 24.12.23 um 15:57 schrieb Krzysztof Kozlowski:
> On 24/12/2023 15:37, Josua Mayer wrote:
>> Convert the existing txt binding for armada-38x socs to DT schema
>> format.
>>
>> Signed-off-by: Josua Mayer <josua at solid-run.com>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time, thus I will skip this patch entirely till you follow
> the process allowing the patch to be tested.
>
> Please kindly resend and include all necessary To/Cc entries.
I am sorry ...
I will verify what get_maintainers said ...

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#select-the-recipients-for-your-patch
I got confused from this guide - what to do when it tells me 3 or more 
lists.
Should I take the most specific one? Or all of them? I.e.:

linux-arm-kernel at lists.infradead.org (moderated list:ARM/Marvell 
Kirkwood and Armada 370, 375, 38x,...)
devicetree at vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE 
TREE BINDINGS)
linux-kernel at vger.kernel.org (open list)

>
>> +
>> +properties:
>> +  $nodename:
>> +    const: '/'
>> +  compatible:
>> +    oneOf:
>> +
>> +      - description: Armada 380 SoC
>> +        items:
>> +          - const: marvell,armada380
>> +
>> +      - description: Armada 385 SoC
>> +        items:
>> +          - const: marvell,armada385
>> +          - const: marvell,armada380
>> +
>> +      - description: Armada 388 SoC
>> +        items:
>> +          - const: marvell,armada388
>> +          - const: marvell,armada385
>> +          - const: marvell,armada380
> These should not be used alone, so such schema is not what we want. We
> want boards to be documented with these SoCs.
There is only one Marvell example for armada-8k:
Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml

I mirrored how that conversion had been done from text to yaml.
If only boards belong in the yaml, then the conversion from txt will 
create an empty file,
to which I could then add specific boards on top.

>
> Best regards,
> Krzysztof
>
sincerely
Josua Mayer



More information about the linux-arm-kernel mailing list