[EXT] Re: [PATCH v2 3/5] dt-bindings: usb: ci-hdrc-usb2: add compatible and clock-names restriction for imx93

Xu Yang xu.yang_2 at nxp.com
Thu Dec 21 05:13:00 PST 2023


Hi Krzysztof,

> 
> On 20/12/2023 03:23, Xu Yang wrote:
> >>> +  - if:
> >>> +      properties:
> >>> +        compatible:
> >>> +          contains:
> >>> +            const: fsl,imx93-usb
> >>> +    then:
> >>> +      properties:
> >>> +        clock-names:
> >>> +          items:
> >>> +            - const: usb_ctrl_root_clk
> >>> +            - const: usb_wakeup_clk
> >>
> >> What about all the reset? reg, interrupts? Maybe it is time to split the
> >> schema into common part and device-specific.
> >
> > Why I need to consider reset, reg and interrupts? Should I add restrictions on
> > these too? I may not really understand your meaning.
> 
> I looked at the binding and it seems that you allow different number of
> items for them. Why aren't these constrained for your device?

Well, understood now. I should add number of clocks and clock-names
for my case. However, reset, reg and interrupts property is not special
for imx93.

Thanks,
Xu Yang

> 
> Best regards,
> Krzysztof



More information about the linux-arm-kernel mailing list