[PATCH 0/3] Add mediatek,gce-events definition to mediatek,gce-mailbox bindings

[Jason-JH Lin (林睿祥)]

Hi Conor,

Thanks for the reviews.

On Tue, 2023-12-19 at 16:54 +0000, Conor Dooley wrote:
> On Mon, Dec 18, 2023 at 04:36:01PM +0800, Jason-JH.Lin wrote:
> > From: Jason-jh Lin <jason-jh.lin at mediatek.corp-partner.google.com>
> > 
> > Since mediatek,gce-events property is a HW event signal from GCE,
> > it should be defined in mediatek,gce-mailbox.yaml.
> > 
> > Change the description of mediatek,gce-events property existed in
> > other bindings to reference mediatek,gce-mailbox.yaml.
> 
> I don't understand this series. I would understand it if the property
> should be related to the mailbox provider and it is moved there from
> the
> mailbox consumer, but this series does not do that. Instead the
> series
> now documents this property for both consumers and providers.
I want to move properties related to MediaTek's proprietary GCE HW to a
common place and let it referenced by mailbox providers and consumers.

And I also want to add this property into a mailbox provider, but maybe
not in this series. I'll move this modification into another series.

> 
> Secondly it removes the typedef from the consumers, which makes no
> sense
> if this is a valid property there.
> 
OK, I will keep the $ref for the consumers.

> Is your intention to document a property that should be common across
> all consumers in a single place? If that is your goal, then something
> like spi-peripheral-props.yaml is what you need here.
> 
Thanks for your example.

Since these properties for the GCE HW are MediaTek specific, I will try
to send a series to create a mediatek,gce-props.yaml to list all these
properties. And modify all these properties in mailbox consumers.

Regards,
Jason-JH.Lin

> Confused,
> Conor.