[PATCH v2 20/27] drm/rockchip: inno_hdmi: Correctly setup HDMI quantization range

Alex Bee knaerzche at gmail.com
Mon Dec 18 04:37:47 PST 2023


Am 18.12.23 um 10:05 schrieb Maxime Ripard:
> On Sat, Dec 16, 2023 at 05:26:31PM +0100, Alex Bee wrote:
>> @@ -431,6 +452,9 @@ static int inno_hdmi_setup(struct inno_hdmi *hdmi,
>>   	else
>>   		inno_conn_state->colorimetry = HDMI_COLORIMETRY_ITU_709;
>>   
>> +	inno_conn_state->rgb_limited_range =
>> +		drm_default_rgb_quant_range(mode) == HDMI_QUANTIZATION_RANGE_LIMITED;
>> +
>>   	/* Mute video and audio output */
>>   	hdmi_modb(hdmi, HDMI_AV_MUTE, m_AUDIO_MUTE | m_VIDEO_BLACK,
>>   		  v_AUDIO_MUTE(1) | v_VIDEO_MUTE(1));
> This needs to be done at atomic_check time: the expectation is that by
> the time you commit the state, everything is prepared for it.
OK. I guess that also applies to the other members of
inno_hdmi_connector_state (former hdmi_data) and was wrong all the time.

Alex
> Maxime



More information about the linux-arm-kernel mailing list