[PATCH v4 3/5] iommu/arm-smmu: add ACTLR data and support for SM8550
Dmitry Baryshkov
dmitry.baryshkov at linaro.org
Sat Dec 16 08:16:45 PST 2023
On 16/12/2023 01:35, Konrad Dybcio wrote:
> On 15.12.2023 11:18, Bibek Kumar Patro wrote:
>> Add ACTLR data table for SM8550 along with support for
>> same including SM8550 specific implementation operations.
>>
>> Signed-off-by: Bibek Kumar Patro <quic_bibekkum at quicinc.com>
>> ---
> [...]
>
>> +static const struct qcom_smmu_match_data sm8550_smmu_500_impl0_data = {
>> + .impl = &qcom_smmu_500_impl,
>> + .adreno_impl = &qcom_adreno_smmu_500_impl,
>> + .cfg = &qcom_smmu_impl0_cfg,
>> + .actlrcfg = sm8550_apps_actlr_cfg,
>> + .actlrcfg_gfx = sm8550_gfx_actlr_cfg,
> There are platforms that feature more than just APPS and Adreno SMMUs,
> this implementation seems to assume there's only these two :/
>
> I suppose the only way to solve this would be to introduce new compatibles
> for each one of them.. Krzysztof, do you think that's reasonable? E.g.
> MSM8996 has at least 5 instances, 8998 has at least 4 etc.
Ugh. I don't think compatibles will make sense here. I think we have to
resolve to the hated solution of putting identifying the instance via
the IO address.
--
With best wishes
Dmitry
More information about the linux-arm-kernel
mailing list