[EXT] Re: [PATCH 4/4] arm64: dts: imx93-11x11-evk: enable usb and typec nodes

[Xu Yang]

Hi Fabio,

>
> On Thu, Dec 14, 2023 at 8:19 AM Xu Yang <xu.yang_2 at nxp.com> wrote:
> >
> > There are 2 Type-C ports and 2 USB controllers on i.MX93. Enable them.
> >
> > Signed-off-by: Xu Yang <xu.yang_2 at nxp.com>
> > ---
> >  .../boot/dts/freescale/imx93-11x11-evk.dts    | 108 ++++++++++++++++++
> >  1 file changed, 108 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > index 2b9d47716f75..42b1ea7d5220 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > @@ -5,6 +5,7 @@
> >
> >  /dts-v1/;
> >
> > +#include <dt-bindings/usb/pd.h>
> >  #include "imx93.dtsi"
> >
> >  / {
> > @@ -103,6 +104,70 @@ &mu2 {
> >         status = "okay";
> >  };
> >
> > +&lpi2c3 {
> > +       #address-cells = <1>;
> > +       #size-cells = <0>;
> > +       clock-frequency = <400000>;
> > +       pinctrl-names = "default", "sleep";
> > +       pinctrl-0 = <&pinctrl_lpi2c3>;
> > +       pinctrl-1 = <&pinctrl_lpi2c3>;
> > +       status = "okay";
> > +
> > +       ptn5110: tcpc at 50 {
> > +               compatible = "nxp,ptn5110";
> > +               reg = <0x50>;
> > +               interrupt-parent = <&gpio3>;
> > +               interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
> > +               status = "okay";
> > +
> > +               port {
> > +                       typec1_dr_sw: endpoint {
> > +                               remote-endpoint = <&usb1_drd_sw>;
> > +                       };
> > +               };
> > +
> > +               typec1_con: connector {
> > +                       compatible = "usb-c-connector";
> > +                       label = "USB-C";
> > +                       power-role = "dual";
> > +                       data-role = "dual";
> > +                       try-power-role = "sink";
> > +                       source-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
> > +                       sink-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)
> > +                                    PDO_VAR(5000, 20000, 3000)>;
> > +                       op-sink-microwatt = <15000000>;
> > +                       self-powered;
>
> Your patch introduce dt-schema warnings.
>
> Port should be placed under connector as per nxp,ptn5110.yaml.

Will fix this in v2.

>
> Please check:
> https://git.kernel.org/pub/scm/linux/kernel/git%25
> 2Fshawnguo%2Flinux.git%2Fcommit%2F%3Fh%3Dfor-
> next%26id%3Dde0bae0b75f288381746bb9f6d6fd1b30f397975&data=05%7C02%7Cxu.yang_2%40nxp.com%7Ce1e0fd394e3c40
> 11339a08dbfc975a81%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638381499208779172%7CUnknown%7CTWFpb
> GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=FoJfshUH
> ngC23vxDSTUfmRVnW%2FKIFMwUw8YZOkR461Y%3D&reserved=0