[PATCH v7 11/16] watchdog: s3c2410_wdt: Update QUIRK macros to use BIT macro

[Peter Griffin]

Hi Alim,

Thanks for your reviews.

On Wed, 13 Dec 2023 at 16:34, Alim Akhtar <alim.akhtar at samsung.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Peter Griffin <peter.griffin at linaro.org>
> > Sent: Monday, December 11, 2023 9:53 PM
> > To: robh+dt at kernel.org; krzysztof.kozlowski+dt at linaro.org;
> > mturquette at baylibre.com; conor+dt at kernel.org; sboyd at kernel.org;
> > tomasz.figa at gmail.com; s.nawrocki at samsung.com; linus.walleij at linaro.org;
> > wim at linux-watchdog.org; linux at roeck-us.net; catalin.marinas at arm.com;
> > will at kernel.org; arnd at arndb.de; olof at lixom.net;
> > gregkh at linuxfoundation.org; jirislaby at kernel.org;
> > cw00.choi at samsung.com; alim.akhtar at samsung.com
> > Cc: peter.griffin at linaro.org; tudor.ambarus at linaro.org;
> > andre.draszik at linaro.org; semen.protsenko at linaro.org;
> > saravanak at google.com; willmcvicker at google.com; soc at kernel.org;
> > devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-
> > samsung-soc at vger.kernel.org; linux-clk at vger.kernel.org; linux-
> > gpio at vger.kernel.org; linux-watchdog at vger.kernel.org; kernel-
> > team at android.com; linux-serial at vger.kernel.org
> > Subject: [PATCH v7 11/16] watchdog: s3c2410_wdt: Update QUIRK macros to
> > use BIT macro
> >
> > Update the remaining QUIRK macros to use the BIT macro.
> >
> Ah! I see you have change use BIT here, so you can squash this patch to
> patch 10/16 or
> Move BIT change from patch 10/16 to this patch. Either way is fine.

I actually kept them separate deliberately to avoid conflating adding
of the DBGACK quirk with cleanup of the driver to use BIT macro.

As such one patch adds the QUIRK and only updates the macros that were
touched by that patch (to avoid the --strict warnings), and the second
patch cleans up the rest of the macros to use BIT macro for
consistency.

regards,

Peter