[PATCH v6 24/40] input: keypad: ep93xx: add DT support for Cirrus EP93xx

Andy Shevchenko andriy.shevchenko at linux.intel.com
Wed Dec 13 10:41:49 PST 2023


On Tue, Dec 12, 2023 at 11:20:41AM +0300, Nikita Shubin wrote:
> - drop flags, they were not used anyway
> - add OF ID match table
> - process "autorepeat", "debounce-delay-ms", prescale from device tree
> - drop platform data usage and it's header
> - keymap goes from device tree now on

...

>  static void ep93xx_keypad_config(struct ep93xx_keypad *keypad)
>  {
>  	unsigned int val = 0;
>  
> +	val |= ((keypad->debounce << KEY_INIT_DBNC_SHIFT) & KEY_INIT_DBNC_MASK);

Since you are touching these lines (see below) you can drop unneeded outer
parentheses.

>  
> +	val |= ((keypad->prescale << KEY_INIT_PRSCL_SHIFT) & KEY_INIT_PRSCL_MASK);

See above.

>  	__raw_writel(val, keypad->mmio_base + KEY_INIT);
>  }

-- 
With Best Regards,
Andy Shevchenko





More information about the linux-arm-kernel mailing list