[PATCH v2 4/9] ARM: dts: rockchip: rv1126: Add i2c2 nodes

[Dragan Simic]

On 2023-11-27 14:07, Dragan Simic wrote:
> On 2023-11-27 12:10, Heiko Stübner wrote:
>> Am Montag, 27. November 2023, 11:55:21 CET schrieb Dragan Simic:
>>> On 2023-11-27 11:50, Heiko Stübner wrote:
>>>> Am Montag, 27. November 2023, 11:43:05 CET schrieb Dragan Simic:
>>>>> Please note there's already an Ethernet alias defined in 
>>>>> rk3399.dtsi,
>>>>> even despite not all RK3399-based devices using the GMAC, for 
>>>>> example
>>>>> the Pinebook Pro.  Perhaps that's something to be fixed as well.
>>>> 
>>>> possibly :-)
>>>> 
>>>> I guess for starters we shouldn't introduce new instances for it.
>>> 
>>> Totally agreed.
>>> 
>>> > All the newer SoCs already have their ethernet alias in the board dts
>>> > (rk356x, rk3568) which came after we also moved the mmc aliases.
>>> 
>>> The base rk3399.dtsi file and the RK3399-based board/device dts(i) 
>>> files
>>> are fine when it comes to the mmc aliases.  I can move forward and 
>>> clean
>>> up the Ethernet alias as well, if you agree?
>> 
>> Yep, we moved mmc aliases a while ago.
>> 
>> So moving the ethernet sounds like the right way forward. So if you 
>> have
>> the time for it, then I'd be quite happy to take patches for that 
>> change.
> 
> Great, thanks.  I'll prepare the patches in the next couple of days,
> and send them over.

I apologize for the delay, I finally got around to implementing and 
verifying these patches for the RK3399, RK3368, RK3328 and PX30 SoC 
dts(i) files. [1]  The way I verified them was to compare the compiled 
dtb files before and after applying the patches.

Also, I went ahead and implemented the patches that add ethernet aliases 
to the RK356x and RK3588 dts board files. [2]  With these patches in 
place, together with the other patches that have already been accepted, 
we should have a rather clean situation when it comes to the Rockchip 
arm64 DT aliases.

[1] 
https://lore.kernel.org/linux-rockchip/cover.1702366958.git.dsimic@manjaro.org/T/#u
[2] 
https://lore.kernel.org/linux-rockchip/cover.1702368023.git.dsimic@manjaro.org/T/#u