[PATCH 2/4] dt-bindings: imx6q-pcie: Add host-wake-gpio property

[Sherry Sun]

> -----Original Message-----
> From: Lucas Stach <l.stach at pengutronix.de>
> Sent: 2023年12月8日 18:00
> To: Sherry Sun <sherry.sun at nxp.com>; Hongxing Zhu
> <hongxing.zhu at nxp.com>; lpieralisi at kernel.org; kw at linux.com;
> robh at kernel.org; bhelgaas at google.com; krzysztof.kozlowski+dt at linaro.org;
> conor+dt at kernel.org; shawnguo at kernel.org; s.hauer at pengutronix.de;
> kernel at pengutronix.de; festevam at gmail.com
> Cc: dl-linux-imx <linux-imx at nxp.com>; linux-pci at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org; devicetree at vger.kernel.org; linux-
> kernel at vger.kernel.org
> Subject: Re: [PATCH 2/4] dt-bindings: imx6q-pcie: Add host-wake-gpio
> property
> 
> Hi Sherry,
> 
> Am Freitag, dem 08.12.2023 um 17:13 +0800 schrieb Sherry Sun:
> > Add host-wake-gpio property that can be used to wakeup the host
> > processor.
> >
> > Signed-off-by: Sherry Sun <sherry.sun at nxp.com>
> > Reviewed-by: Richard Zhu <hongxing.zhu at nxp.com>
> > ---
> >  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > index 81bbb8728f0f..944f0f961809 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > @@ -72,6 +72,10 @@ properties:
> >        L=operation state) (optional required).
> >      type: boolean
> >
> > +  host-wake-gpio:
> 
> There is only one wake signal in PCIe and it has a defined direction, so there
> is no point in specifying that it is a host wakeup. Also GPIO handles without a
> traling 's' are deprecated. So this should be
> 
> wake-gpios

Hi Lucas, thanks for the comment, will change it in V2.

> 
> > +    description: Should specify the GPIO for controlling the PCI bus device
> > +      wake signal, used to wakeup the host processor. Default to active-low.
> 
> The description is wrong. For the RC complex case (which is the binding you
> are modifying here) the controller does not control the wake signal, but
> instead uses it as a input. The description should reflect that.
> 
> The default is also quite useless, as your implementation does not allow to
> change it. Please translate the GPIO active flags from the DT to the proper
> IRQ flags and drop this default here. The DT should simply carry the proper
> polarity.
> 

Will improve the description in V2, thanks.

Best Regards
Sherry