[PATCH net-next v2] net: stmmac: don't create a MDIO bus if unnecessary
Andrew Lunn
andrew at lunn.ch
Thu Dec 7 13:30:23 PST 2023
On Wed, Dec 06, 2023 at 05:46:09PM -0600, Andrew Halaney wrote:
> The stmmac_dt_phy() function, which parses the devicetree node of the
> MAC and ultimately causes MDIO bus allocation, misinterprets what
> fixed-link means in relation to the MAC's MDIO bus. This results in
> a MDIO bus being created in situations it need not be.
Please extend that with something like....
This is bad, because ....
Most 'clean' driver unconditionally create the MDIO bus. But stmmac is
not that clean, and has to keep backwards compatibility to some old
usage. I'm just wondering what this patch actually brings us, and is
it worth it. Is it fixing a real bug, or just an optimisation?
Andrew
More information about the linux-arm-kernel
mailing list