[PATCH] irqchip/gic-v3-its: BUG_ON if stall bit is set

[Marc Zyngier]

On Thu, 07 Dec 2023 06:12:39 +0000,
Mukesh Ojha <quic_mojha at quicinc.com> wrote:
> 
> There could be various reason that stall bit could
> be set due to software errors while processing
> commands in command queue is being processed and

Such as?

> waiting for 1s is not going to help in debugging
> as command processing anyways going to be timed
> out and system will continue to run and may crash
> after some time due to this.
> 
> So, to debug such issues what command caused the
> stall bit to set, BUG_ON right away.

How on Earth will killing the system allow *anything* to be further
debugged?

If you need debug information, add the correct debug statements using
pr_debug(). Even better, try to gracefully recover from it if the ITS
command queue supports restarting.

Crashing the system is not an option.

	M.

-- 
Without deviation from the norm, progress is not possible.