[PATCH] ARM: dts: imx28-tx28: Pass #sound-dai-cells

Stefan Wahren wahrenst at gmx.net
Tue Dec 5 10:32:00 PST 2023


Hi Fabio,

Am 05.12.23 um 15:53 schrieb Fabio Estevam:
> From: Fabio Estevam <festevam at denx.de>
>
> Per sgtl5000.yaml, '#sound-dai-cells' is a required property.
>
> Pass it to fix the following dt-schema warning:
>
> imx28-tx28.dtb: sgtl5000 at a: '#sound-dai-cells' is a required property
> 	from schema $id: http://devicetree.org/schemas/sound/sgtl5000.yaml#
>
> Signed-off-by: Fabio Estevam <festevam at denx.de>
> ---
>   arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts b/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts
> index 153e4017951d..5485fe118dc4 100644
> --- a/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts
> @@ -260,6 +260,7 @@ &i2c0 {
>   	sgtl5000: sgtl5000 at a {
this patch is fine

Reviewed-by: Stefan Wahren <wahrenst at gmx.net>

but this node name looks wrong.

It should be sgtl5000: codec at a

Regards
>   		compatible = "fsl,sgtl5000";
>   		reg = <0x0a>;
> +		#sound-dai-cells = <0>;
>   		VDDA-supply = <&reg_2p5v>;
>   		VDDIO-supply = <&reg_3p3v>;
>   		clocks = <&mclk>;




More information about the linux-arm-kernel mailing list