[PATCH v6 03/41] arm64: mm: get rid of kimage_vaddr global variable

[Mark Rutland]

On Thu, Nov 30, 2023 at 11:08:59AM +0530, Anshuman Khandual wrote:
> 
> 
> On 11/29/23 16:45, Ard Biesheuvel wrote:
> > From: Ard Biesheuvel <ardb at kernel.org>
> > 
> > We store the address of _text in kimage_vaddr, but since commit
> > 09e3c22a86f6889d ("arm64: Use a variable to store non-global mappings
> > decision"), we no longer reference this variable from modules so we no
> > longer need to export it.
> > 
> > In fact, we don't need it at all so let's just get rid of it.
> > 
> > Acked-by: Mark Rutland <mark.rutland at arm.com>
> > Signed-off-by: Ard Biesheuvel <ardb at kernel.org>
> 
> There is a checkpatch.pl error for this patch.
> 
> --------
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' -
> ie: 'commit 09e3c22a86f6 ("arm64: Use a variable to store non-global mappings decision")'
> #6: 
> We store the address of _text in kimage_vaddr, but since commit
> --------

That looks like a spurious warning. Ard wrote:

  [...] commit 09e3c22a86f6889d ("arm64: Use a variable to store non-global
  mappings decision"), [...]

... which is 'commit <16 chars of sha1> ("<title line>")', just as the
checkpatch message says.

Clearly, this checkpatch warning isn't helpful.

Regardless of whether the warning is spurious, please use judgement for
checkpatch warnings. They're not always a hard rule to be followed.

Mark.