[PATCH v8 06/13] coresight-tpdm: Add reset node to TPDM node
Tao Zhang
quic_taozha at quicinc.com
Thu Aug 31 19:09:17 PDT 2023
On 9/1/2023 4:34 AM, Suzuki K Poulose wrote:
> On 22/08/2023 06:26, Tao Zhang wrote:
>> TPDM device need a node to reset the configurations and status of
>> it. This change provides a node to reset the configurations and
>> disable the TPDM if it has been enabled.
>>
>> Signed-off-by: Tao Zhang <quic_taozha at quicinc.com>
>> ---
>> .../ABI/testing/sysfs-bus-coresight-devices-tpdm | 10 ++++++++++
>> drivers/hwtracing/coresight/coresight-tpdm.c | 22
>> ++++++++++++++++++++++
>> 2 files changed, 32 insertions(+)
>>
>> diff --git
>> a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
>> b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
>> index 4a58e64..2936226 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
>> +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
>> @@ -11,3 +11,13 @@ Description:
>> Accepts only one of the 2 values - 1 or 2.
>> 1 : Generate 64 bits data
>> 2 : Generate 32 bits data
>> +
>> +What: /sys/bus/coresight/devices/<tpdm-name>/reset_dataset
>> +Date: March 2023
>> +KernelVersion 6.5
>> +Contact: Jinlong Mao (QUIC) <quic_jinlmao at quicinc.com>, Tao Zhang
>> (QUIC) <quic_taozha at quicinc.com>
>> +Description:
>> + (Write) Reset the dataset of the tpdm.
>> +
>> + Accepts only one value - 1.
>> + 1 : Reset the dataset of the tpdm
>> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c
>> b/drivers/hwtracing/coresight/coresight-tpdm.c
>> index 951ad4d..d6e7c8c 100644
>> --- a/drivers/hwtracing/coresight/coresight-tpdm.c
>> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c
>> @@ -162,6 +162,27 @@ static int tpdm_datasets_setup(struct
>> tpdm_drvdata *drvdata)
>> return 0;
>> }
>> +static ssize_t reset_dataset_store(struct device *dev,
>> + struct device_attribute *attr,
>> + const char *buf,
>> + size_t size)
>> +{
>> + int ret = 0;
>> + unsigned long val;
>> + struct tpdm_drvdata *drvdata = dev_get_drvdata(dev->parent);
>> +
>> + ret = kstrtoul(buf, 0, &val);
>> + if (ret || val != 1)
>> + return -EINVAL;
>> +
>> + spin_lock(&drvdata->spinlock);
>> + tpdm_reset_datasets(drvdata);
>> + spin_unlock(&drvdata->spinlock);
>> +
>> + return size;
>> +}
>> +static DEVICE_ATTR_WO(reset_dataset);
>> +
>> /*
>> * value 1: 64 bits test data
>> * value 2: 32 bits test data
>> @@ -202,6 +223,7 @@ static ssize_t integration_test_store(struct
>> device *dev,
>> static DEVICE_ATTR_WO(integration_test);
>> static struct attribute *tpdm_attrs[] = {
>> + &dev_attr_reset_dataset.attr,
>
> Should this be only visible when DSB data set is present ?
This sysfs file doesn't only reset DSB dataset, and it needs to reset
all the datasets the TPDM supported.
So I think it should not be only visible for DSB TPDM
Best,
Tao
>
> Suzuki
>
>> &dev_attr_integration_test.attr,
>> NULL,
>> };
>
More information about the linux-arm-kernel
mailing list