[PATCH -next v3 0/3] iio: adc: at91_adc: Cleanup with the helpers

Jinjie Ruan ruanjinjie at huawei.com
Sun Aug 27 23:45:43 PDT 2023


Commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared
and enabled clocks") provides a new helper function to prepare and
enable a clock which keeps prepared (or enabled) during the whole
lifetime of the driver.

Use devm_request_irq() to request the interrupt, so we can
avoid having to manually clean this up.

Use the dev_err_probe() helper to simplify error handling during probe.
This also handle scenario, when EDEFER is returned and useless
error is printed.

changes in v3:
- Take the last remove free_irq() and add it to be the first devm managed.
- Not going any longer than 80 chars than is necessary.

Changes in v2:
- Also use devm_request_irq() and dev_err_probe() to clean up the at91_adc.
- Split the at91_adc patch out to be a new patch set.

Jinjie Ruan (3):
  iio: adc: at91_adc: Use devm_request_irq() helper function
  iio: adc: at91_adc: Use devm_clk_get_enabled() helper function
  iio: adc: at91_adc: Simplify with dev_err_probe()

 drivers/iio/adc/at91_adc.c | 108 +++++++++++++------------------------
 1 file changed, 37 insertions(+), 71 deletions(-)

-- 
2.34.1




More information about the linux-arm-kernel mailing list