[PATCH] coresight: tmc-etr: Don't fail probe when non-secure access is disabled

Suzuki K Poulose suzuki.poulose at arm.com
Sun Aug 27 14:37:38 PDT 2023


On 26/08/2023 00:39, Yabin Cui wrote:
> Because the non-secure access can be enabled later on some devices.

How can this be enabled ? Why not enable it before probing the ETR ?
How can a user know if this has been done or not ? It is asking for
trouble to continue without this.

Suzuki

> 
> Signed-off-by: Yabin Cui <yabinc at google.com>
> ---
>   drivers/hwtracing/coresight/coresight-tmc-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c
> index c106d142e632..5ebfd12b627b 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc-core.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c
> @@ -370,7 +370,7 @@ static int tmc_etr_setup_caps(struct device *parent, u32 devid, void *dev_caps)
>   	struct tmc_drvdata *drvdata = dev_get_drvdata(parent);
>   
>   	if (!tmc_etr_has_non_secure_access(drvdata))
> -		return -EACCES;
> +		dev_warn(parent, "TMC ETR doesn't have non-secure access\n");
>   
>   	/* Set the unadvertised capabilities */
>   	tmc_etr_init_caps(drvdata, (u32)(unsigned long)dev_caps);




More information about the linux-arm-kernel mailing list