[PATCH] [PATCH 5.10] iommu/mediatek: remove redundant comparison

Alexandra Diupina adiupina at astralinux.ru
Thu Aug 24 06:09:54 PDT 2023


iommu_device_register always returns 0 in 4.11-5.12, so
we need to remove redundant comparison with 0

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: b16c0170b53c ("iommu/mediatek: Make use of iommu_device_register interface")
Signed-off-by: Alexandra Diupina <adiupina at astralinux.ru>
---
 drivers/iommu/mtk_iommu.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index 051815c9d2bb..208c47218b75 100644
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -748,9 +748,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
 	iommu_device_set_ops(&data->iommu, &mtk_iommu_ops);
 	iommu_device_set_fwnode(&data->iommu, &pdev->dev.of_node->fwnode);
 
-	ret = iommu_device_register(&data->iommu);
-	if (ret)
-		return ret;
+	iommu_device_register(&data->iommu);
 
 	spin_lock_init(&data->tlb_lock);
 	list_add_tail(&data->list, &m4ulist);
-- 
2.30.2




More information about the linux-arm-kernel mailing list