[PATCH net v2] net: ethernet: mtk_eth_soc: fix NULL pointer on hw reset

[Lorenzo Bianconi]

> When a hardware reset is triggered on devices not initializing WED the
> calls to mtk_wed_fe_reset and mtk_wed_fe_reset_complete dereference a
> pointer on uninitialized stack memory.
> Break out of both functions in case a hw_list entry is 0.
> 
> Fixes: 08a764a7c51b ("net: ethernet: mtk_wed: add reset/reset_complete callbacks")
> Signed-off-by: Daniel Golle <daniel at makrotopia.org>

Acked-by: Lorenzo Bianconi <lorenzo at kernel.org>

> Reviewed-by: Simon Horman <horms at kernel.org>
> ---
> Changes since v1:
>  * remove unneeded {} initialization for stack allocated memory
> 
>  drivers/net/ethernet/mediatek/mtk_wed.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mediatek/mtk_wed.c b/drivers/net/ethernet/mediatek/mtk_wed.c
> index 00aeee0d5e45f..94376aa2b34c5 100644
> --- a/drivers/net/ethernet/mediatek/mtk_wed.c
> +++ b/drivers/net/ethernet/mediatek/mtk_wed.c
> @@ -222,9 +222,13 @@ void mtk_wed_fe_reset(void)
>  
>  	for (i = 0; i < ARRAY_SIZE(hw_list); i++) {
>  		struct mtk_wed_hw *hw = hw_list[i];
> -		struct mtk_wed_device *dev = hw->wed_dev;
> +		struct mtk_wed_device *dev;
>  		int err;
>  
> +		if (!hw)
> +			break;
> +
> +		dev = hw->wed_dev;
>  		if (!dev || !dev->wlan.reset)
>  			continue;
>  
> @@ -245,8 +249,12 @@ void mtk_wed_fe_reset_complete(void)
>  
>  	for (i = 0; i < ARRAY_SIZE(hw_list); i++) {
>  		struct mtk_wed_hw *hw = hw_list[i];
> -		struct mtk_wed_device *dev = hw->wed_dev;
> +		struct mtk_wed_device *dev;
> +
> +		if (!hw)
> +			break;
>  
> +		dev = hw->wed_dev;
>  		if (!dev || !dev->wlan.reset_complete)
>  			continue;
>  
> -- 
> 2.41.0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20230821/e6403284/attachment-0001.sig>