[PATCH v6 09/10] iommu/arm-smmu-v3: Skip cd sync if CD table isn't active

Michael Shavit mshavit at google.com
Mon Aug 21 03:16:08 PDT 2023


On Wed, Aug 16, 2023 at 9:20 PM Michael Shavit <mshavit at google.com> wrote:
>
> This commit explicitly keeps track of whether a CD table is installed in
> an STE so that arm_smmu_sync_cd can skip the sync when unnecessary. This
> was previously achieved through the domain->devices list, but we are
> moving to a model where arm_smmu_sync_cd directly operates on a master
> and the master's CD table instead of a domain.
>
> Reviewed-by: Jason Gunthorpe <jgg at nvidia.com>
> Reviewed-by: Nicolin Chen <nicolinc at nvidia.com>
> Signed-off-by: Michael Shavit <mshavit at google.com>
> ---
> Happy to drop this commit if we don't think it's useful.

Hi Will,
Do you have any recommendations for keeping or dropping this commit in
the end? It's only purpose is to minimize any potential performance
impact from the refactor but can certainly be dropped if you don't
think it's worth the complication.



More information about the linux-arm-kernel mailing list